-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the collection context in the type check context. #6460
Introduce the collection context in the type check context. #6460
Conversation
61d53a9
to
20b93ce
Compare
e76e5ac
to
6a8f29c
Compare
6a8f29c
to
5101f16
Compare
CodSpeed Performance ReportMerging #6460 will not alter performanceComparing Summary
|
Updated the PR, rebased on top of the latest master and also some minor improvents to error handling in some cases.
I have seen this same slowdown in #6553, so I don't think its specific to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one, excited to see this progress.
Description
This PR does a couple things:
This prepares the compiler for a future PR where the additional namespace will be able to be removed from the type checking, and with it the cloning we do as we type check.
Checklist
Breaking*
orNew Feature
labels where relevant.